doc: mention that node options are space-separated #14709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
The documentation does not mention that the value of NODE_OPTIONS is a space-separated list.
gabrielschulhof
force-pushed
the
node-options-are-space-separated
branch
from
445c1ee to
cff4124
Compare
lpinca
approved these changes
Aug 9, 2017
vsemozhetbyt
approved these changes
Aug 9, 2017
vsemozhetbyt
added
the
cli
cjihrig
approved these changes
Aug 9, 2017
jasnell
approved these changes
Aug 10, 2017
gibfahn
approved these changes
Aug 12, 2017
|
More recent CI: https://ci.nodejs.org/job/node-test-pull-request/9638/ |
|
Landed in 6fe72c8. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Aug 13, 2017
The documentation does not mention that the value of NODE_OPTIONS is a space-separated list. PR-URL: #14709 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 13, 2017
The documentation does not mention that the value of NODE_OPTIONS is a space-separated list. PR-URL: #14709 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not mention that the value of NODE_OPTIONS is a
space-separated list.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc